-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python API #69
Python API #69
Conversation
Circumventing gflags helps since it is not always available or linked correctly. An alternative solution would be to automatically make gflags available through FetchContent, but we would rather keep the number of auto-fetched libraries small to reduce compatibility struggles. Furthermore, our library currently disables the option to install if any dependency is auto-fetched.
library/python/src/pipeline.cc
Outdated
.def("clear", &Pipeline::clear, | ||
"Deregister all the pipeline's measurement integrators and map " | ||
"operations.") | ||
.def("hasIntegrator", &Pipeline::hasIntegrator, "integrator_name"_a, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be has_integrator
or alternatively integrator_name in pipeline
. The in
keyword is used in python to check for existence of an object in a different thing, often lists, maps, etc. So might not be the most sensible here to be honest unless you return a list of integrators but then it's on the user to implement the check.
49879f8
to
450d9ae
Compare
Description
This PR introduces pywavemap, a Python API for the wavemap library.
Type of change
Detailed summary
This PR extends wavemap 2.0 with a full-fledged Python API, enabling the creation, reading, and writing of map files. Users can configure and run modular mapping pipelines directly in Python. The API includes fast, batched map accessors optimized for PyTorch and other machine learning frameworks. Additionally, the CI pipeline has been rewritten for improved testing and easier future extensions.
Testing
Unit tests for pywavemap have been implemented using pytest.
The CI pipeline has been extended to automatically build and test pywavemap, alongside other major improvements (see above).
Checklist: