Skip to content

Conversation

GiulioRomualdi
Copy link
Contributor

@GiulioRomualdi GiulioRomualdi commented Sep 1, 2025

Description

This PR fixes #3266, adding the possibility to randomize the friction coefficient when isaacsim is higher than 5.0.0

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

Not applicable

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

GiulioRomualdi and others added 4 commits September 8, 2025 21:05
Co-authored-by: James Tigue <[email protected]>
Signed-off-by: Giulio Romualdi <[email protected]>
Co-authored-by: James Tigue <[email protected]>
Signed-off-by: Giulio Romualdi <[email protected]>
Co-authored-by: James Tigue <[email protected]>
Signed-off-by: Giulio Romualdi <[email protected]>
@jtigue-bdai
Copy link
Collaborator

Thanks for the additions. Can you add to this test?

def test_write_joint_frictions_to_sim(sim, num_articulations, device, add_ground_plane):

And can you update:
Extension version

Change log

@GiulioRomualdi
Copy link
Contributor Author

Thanks for the additions. Can you add to this test?

def test_write_joint_frictions_to_sim(sim, num_articulations, device, add_ground_plane):

And can you update: Extension version

Change log

Hi @jtigue-bdai! You are welcome!!

18f3a32 implements the test
bb275bf bump the version

@Mayankm96 Mayankm96 changed the title Add support for randomize joint friction coefficients in simulation based on IsaacSim 5.0.0 Randomize joint friction coefficients in simulation based on IsaacSim 5.0.0 Sep 11, 2025
Signed-off-by: Mayank Mittal <[email protected]>
@github-actions github-actions bot added the isaac-lab Related to Isaac Lab team label Sep 11, 2025
@Mayankm96 Mayankm96 changed the title Randomize joint friction coefficients in simulation based on IsaacSim 5.0.0 Randomizes viscous and dynamic joint friction coefficients based on IsaacSim 5.0.0 Sep 11, 2025
@Mayankm96 Mayankm96 changed the title Randomizes viscous and dynamic joint friction coefficients based on IsaacSim 5.0.0 Randomizes viscous and dynamic joint friction coefficients based on IsaacSim 5.0 Sep 11, 2025
@Mayankm96 Mayankm96 added the enhancement New feature or request label Sep 11, 2025
@Mayankm96 Mayankm96 changed the title Randomizes viscous and dynamic joint friction coefficients based on IsaacSim 5.0 Randomizes viscous and dynamic joint friction based on IsaacSim 5.0 Sep 11, 2025
@GiulioRomualdi
Copy link
Contributor Author

Build and Test / test-general seems failing but I'm not able to find the error, could you please pointing me the correct file I should check?

@GiulioRomualdi
Copy link
Contributor Author

bfafb24 fixes the formatting that was causing an issue in the CI

Copy link
Collaborator

@jtigue-bdai jtigue-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request isaac-lab Related to Isaac Lab team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] randomize_joint_parameters only updates static friction and may violate PhysX constraint (static < dynamic friction)
3 participants