-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Randomizes viscous and dynamic joint friction based on IsaacSim 5.0 #3318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…iscous coefficients in simulation
Co-authored-by: James Tigue <[email protected]> Signed-off-by: Giulio Romualdi <[email protected]>
Co-authored-by: James Tigue <[email protected]> Signed-off-by: Giulio Romualdi <[email protected]>
Co-authored-by: James Tigue <[email protected]> Signed-off-by: Giulio Romualdi <[email protected]>
Thanks for the additions. Can you add to this test?
And can you update:
Change log
|
Hi @jtigue-bdai! You are welcome!! |
Signed-off-by: Mayank Mittal <[email protected]>
Signed-off-by: Mayank Mittal <[email protected]>
Build and Test / test-general seems failing but I'm not able to find the error, could you please pointing me the correct file I should check? |
bfafb24 fixes the formatting that was causing an issue in the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Mayank Mittal <[email protected]>
Signed-off-by: Mayank Mittal <[email protected]>
Signed-off-by: Mayank Mittal <[email protected]>
Description
This PR fixes #3266, adding the possibility to randomize the friction coefficient when isaacsim is higher than 5.0.0
Type of change
Screenshots
Not applicable
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there