Add new members for PID controller parameters #1585
Draft
+41
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
destogl,
LukasMacha97,
mamueluth,
mcbed,
progtologist and
saikishor
|
I set this as draft until we approved the control_toolbox PR. |
Adds new members to PID controller parameters to support saturation and three new anti-windup features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new members to the PID controller parameters to support saturation and three new anti-windup features.
These changes support modifications made to the PID controller in the control_toolbox package. For more details, see ros-controls/control_toolbox#298.
If this PR is approved, it should be merged together with the main PR in the control_toolbox package referenced above.