-
Notifications
You must be signed in to change notification settings - Fork 389
Update realtime containers #1721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f093e00
to
ba875d3
Compare
This pull request is in conflict. Could you fix it @christophfroehlich? |
This pull request is in conflict. Could you fix it @christophfroehlich? |
This pull request is in conflict. Could you fix it @christophfroehlich? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -58,7 +72,7 @@ controller_interface::CallbackReturn ForwardControllersBase::on_configure( | |||
|
|||
joints_command_subscriber_ = get_node()->create_subscription<CmdType>( | |||
"~/commands", rclcpp::SystemDefaultsQoS(), | |||
[this](const CmdType::SharedPtr msg) { rt_command_ptr_.writeFromNonRT(msg); }); | |||
[this](const CmdType::SharedPtr msg) { rt_command_.set(*msg); }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be we should check here with std::all_of that all of the data elements are finite values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a behavior change right? maybe we can do that in a follow-up PR?
Apply changes from the guidelines added with ros-controls/realtime_tools#347