AP_HAL_ChibiOS: add hwdef files for NarinFC-H7 #29241
Conversation
|
Someone please tell me what to do. |
|
#Peterbarker |
|
|
@vololand why do you add merge commits to this pr and the wiki one? it clutters the commit history and invalidates any review comments... |
There was a problem hiding this comment.
good start on readme but needs more info....see this draft guide I have done:
ArduPilot/ardupilot_wiki#6645
@Hwurzburg |
@Hwurzburg example 1: example 2: example 3: |
|
yes you dont merge master into your working branch, you REBASE it on master if you want to update it....but updating to master will be done when it get approved and merged into master, so you don't have to continually update your PR unless something master impacts it (not usual for bd PRs) |
@Hwurzburg |
There was a problem hiding this comment.
- Serial6/UART7 connector not show or pins listed
- If we want to recommend it for duplex RC like CRSF it MUST have DMA...remove the NODMA in hwdef...it allocates okay, I checked
- you say all motor/servco outputs are Bidir DShot capable...at this time NONE are and outputs 13 and 14 cant do DSHot, which you state they can
- you define a spare ADC ports, but they are not show in pinout image or lists
- the APJ_BOARD_ID in both hwdef files should be AP_HW_NarinH7 not 1183
- the GPIO pin numbers for RSSI_IN, the spare ADCs should be listed in the readme
There was a problem hiding this comment.
- you added ADC and RSSI conenctor but images do not show where they are located
- SERAIL6 need DMA capable notation in readme
- You have batt mon params in defaults.parm file (those should be moved to hwdef defines not in defaults file), but if you ship the autopilot with the DroneCAN power module, this should be what the Battery Monitor section in the Readme discusses not analog monitor....if you ship an analog monitor then BATT_MONITOR should be 4 in the hwdef....if you will ship with either option, then both should be discussed in the readme section instructions on how to configure for analog or DroneCAN.
getting close
|
Thanks...I have tweaked the README a little, squashed, and split...I have approved and marked for next devcall |
|
Ping @andyp1per |
|
@andyp1per will review |
|
@vololand I added bdshot to PWM 1-8 - this works quite nicely. Do you really intend to ship all of these IMUs? If not you should remove the ones that will never be on the board as they are currently chewing up DMA channels for SPI. |
|
Readme needs changes after Andy's commits...in output and RCin sections |
@andyp1per |
@Hwurzburg |
Co-authored-by: Henry Wurzburg <[email protected]>
|
@Hwurzburg |
|
AP_HAL_ChibiOS: add hwdef files for NarinFC-H7
(ArduPilot/ardupilot:master <--- vololand/ardupilot:NarinFC-H7)