-
Notifications
You must be signed in to change notification settings - Fork 138
Change WireBundle::Ctrl to WireBundle::TileControl. Decouple WireBundle and StrmSwPortType #2010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
While I'm normally very much in favor of avoiding abbreviations, I'm not 100% on board with this. The WireBundle names come from the architecture and at some point it's not good to have that inconsistency. But I guess there has to be some friction somewhere, the only question is where is the least confusing place for it to be? |
Coverage ReportCreated: 2025-01-08 21:36Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 14.0.0 |
As far as I know the |
I think it came from the AIE1 arch spec. TileControl indeed might be better? Given that it is itself inconsistent, I remove my objection :) |
Updated to TileControl to be more....consistent. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Revert unintended find/replace
revert unintended find/replace
This changes replaces the abbreviated
WireBundle::Ctrl
withWireBundle::TileControl
and removes an implicit coupling between theWireBundle
enum names and the aie-rtStrmSwPortType
enum names.Previously the xaie target (e.g.
aie-translate --aie-generate-xaie
) used the TableGen'dwireBundleStringify
functions to emitStrmSwPortType
enums directly as C++ source code. This PR replaces uses ofwireBundleStringify
inAIETargetXAIEV2
with a new utility function. This corrects a potential bug related to thePL
port and allows the renaming of the control port.