Update WGPU to version 22 #14401
Update WGPU to version 22 #14401
Conversation
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
| trace = ["profiling"] | ||
| tracing-tracy = [] | ||
| wgpu_trace = ["wgpu/trace"] | ||
| wgpu_trace = [] |
There was a problem hiding this comment.
wgpu_trace was temporarily removed gfx-rs/wgpu#5974. We should remove our feature for now too imo (and the corresponding docs we have referencing it).
There was a problem hiding this comment.
Hi, I was browsing around and looking at Bevy's PRs, so please excuse me if I seem a bit out of place.
I assume that if the wgpu_trace feature is removed, it'll be re-added back eventually? If so, then I might recommend keeping the wgpu_trace feature, but have a note somewhere (in the docs? during compilation? as a compile error? etc.) that the feature does not currently work, linking to the wgpu issue you mentioned.
That said, if you actually mean to remove it permanently, then my suggestion would be nil.
(P.S. Personally, I don't see the use in this feature, compared to just saying "pull in wgpu and include the trace feature". But that's me - maybe bevy has the wgpu_trace feature for a reason I'm not aware of?)
There was a problem hiding this comment.
I'm in favor of just removing it outright, but if we really wanted to keep it, putting in a compile error with a link to an issue seems like a good idea to me.
| label: options.device_label.as_ref().map(AsRef::as_ref), | ||
| required_features: features, | ||
| required_limits: limits, | ||
| memory_hints: wgpu::MemoryHints::default(), |
There was a problem hiding this comment.
Probably want to expose this in the render plugin settings like we do with other things.
alice-i-cecile
added
A-Rendering
|
naga_oil has been updated to wgpu 22 and is now published. Can you update this PR with the new naga_oil version? |
|
PR for that callym#1 edit: It should be good to go after that. |
Elabajaba
left a comment
Elabajaba
left a comment
There was a problem hiding this comment.
LGTM, just 1 tiny change.
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
LGTM, I tested a few examples and it all seems to work as expected
IceSentry
added
S-Ready-For-Final-Review
6 participants
Upgrading to WGPU 22.
Needs
naga_oilto upgrade first, I've got a fork that compiles but fails tests, so until that's fixed and the crate is officially updated/released this will be blocked.