Skip to content

Revert temporary logging changes added for CI timeout investigation #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Juliaj
Copy link
Contributor

@Juliaj Juliaj commented Jun 6, 2025

Revert #1639.

It looks like @saikishor's fix in the the destructor of RealtimePublisher is working.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.
Let's wait for us to fix the CI issue

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (97dd175) to head (e3a2d28).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1741   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files         123      123           
  Lines       11942    11940    -2     
  Branches      995      994    -1     
=======================================
- Hits        10306    10305    -1     
  Misses       1333     1333           
+ Partials      303      302    -1     
Flag Coverage Δ
unittests 86.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roadcaster/src/force_torque_sensor_broadcaster.cpp 90.90% <ø> (ø)
...ster/test/test_force_torque_sensor_broadcaster.cpp 98.15% <100.00%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit e00d4cb into ros-controls:master Jun 7, 2025
18 of 26 checks passed
mergify bot pushed a commit that referenced this pull request Jun 7, 2025
saikishor pushed a commit that referenced this pull request Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants