Skip to content

Comments

Revert temporary logging changes added for CI timeout investigation#1741

Merged
christophfroehlich merged 2 commits intoros-controls:masterfrom
Juliaj:revert_ci_timeout_change_1639_1
Jun 7, 2025
Merged

Revert temporary logging changes added for CI timeout investigation#1741
christophfroehlich merged 2 commits intoros-controls:masterfrom
Juliaj:revert_ci_timeout_change_1639_1

Conversation

@Juliaj
Copy link
Contributor

@Juliaj Juliaj commented Jun 6, 2025

Revert #1639.

It looks like @saikishor's fix in the the destructor of RealtimePublisher is working.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.
Let's wait for us to fix the CI issue

Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (97dd175) to head (e3a2d28).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1741   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files         123      123           
  Lines       11942    11940    -2     
  Branches      995      994    -1     
=======================================
- Hits        10306    10305    -1     
  Misses       1333     1333           
+ Partials      303      302    -1     
Flag Coverage Δ
unittests 86.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roadcaster/src/force_torque_sensor_broadcaster.cpp 90.90% <ø> (ø)
...ster/test/test_force_torque_sensor_broadcaster.cpp 98.15% <100.00%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Jun 7, 2025
@christophfroehlich christophfroehlich merged commit e00d4cb into ros-controls:master Jun 7, 2025
18 of 26 checks passed
mergify bot pushed a commit that referenced this pull request Jun 7, 2025
saikishor pushed a commit that referenced this pull request Jun 7, 2025
…backport #1741) (#1747)

Co-authored-by: Julia Jia <juliajster@gmail.com>
@Juliaj Juliaj deleted the revert_ci_timeout_change_1639_1 branch June 10, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants