Revert temporary logging changes added for CI timeout investigation#1741
Merged
christophfroehlich merged 2 commits intoros-controls:masterfrom Jun 7, 2025
Merged
Conversation
saikishor
reviewed
Jun 7, 2025
Member
saikishor
left a comment
There was a problem hiding this comment.
The changes look good to me.
Let's wait for us to fix the CI issue
bmagyar
approved these changes
Jun 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1741 +/- ##
=======================================
Coverage 86.30% 86.30%
=======================================
Files 123 123
Lines 11942 11940 -2
Branches 995 994 -1
=======================================
- Hits 10306 10305 -1
Misses 1333 1333
+ Partials 303 302 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
approved these changes
Jun 7, 2025
e00d4cb
into
ros-controls:master
18 of 26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #1639.
It looks like @saikishor's fix in the the destructor of
RealtimePublisheris working.