-
Notifications
You must be signed in to change notification settings - Fork 374
Revert temporary logging changes added for CI timeout investigation #1741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert temporary logging changes added for CI timeout investigation #1741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
Let's wait for us to fix the CI issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1741 +/- ##
=======================================
Coverage 86.30% 86.30%
=======================================
Files 123 123
Lines 11942 11940 -2
Branches 995 994 -1
=======================================
- Hits 10306 10305 -1
Misses 1333 1333
+ Partials 303 302 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
e00d4cb
into
ros-controls:master
…backport #1741) (#1747) Co-authored-by: Julia Jia <[email protected]>
Revert #1639.
It looks like @saikishor's fix in the the destructor of
RealtimePublisher
is working.