Display scmsync package actions #18372
Conversation
hennevogel
added
the
review-app
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
hellcp-work
force-pushed
the
scmsync-package
branch
4 times, most recently
from
7966254 to
caab5fe
Compare
|
could you hide this version of the sources by default? These are not the sources which are processed when rpmbuild runs and neither what is maintained in git. Esp. when we start now using subdirectories it willl lead to confusion... so, maybe just collapsing it and show it only on request (mouse click). Also, the scmsync url itself seems not to be displayed. The showing URL is the project url from tag, right? |
Doable
It is, both in the project's package list and also in the top right (Developed at SCM link) |
|
| | Also, the scmsync url itself seems not to be displayed. The showing URL is the project url from tag, right? I see, maybe we can have that link more prominent by default. For example showing this one instead of the sources by default. |
hellcp-work
force-pushed
the
scmsync-package
branch
from
caab5fe to
fa7caf0
Compare
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
2 similar comments
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
hellcp-work
force-pushed
the
scmsync-package
branch
from
607d67a to
1294f76
Compare
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
7 similar comments
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
hellcp-work
force-pushed
the
scmsync-package
branch
from
1294f76 to
c4389a5
Compare
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
hellcp-work
force-pushed
the
scmsync-package
branch
4 times, most recently
from
09a5f37 to
0437cb8
Compare
hellcp-work
force-pushed
the
scmsync-package
branch
from
0437cb8 to
cefbb90
Compare
| @package = Package.get_by_project_and_name(@project.name, @package_name, follow_multibuild: true) | ||
| @package = Package.get_by_project_and_name(@project.name, @package_name, | ||
| follow_multibuild: true, | ||
| follow_project_scmsync_links: Flipper.enabled?(:scmsync, User.session)) |
There was a problem hiding this comment.
This will expose readonly packages to all controllers that use this before action. I don't think this is a good idea.
There was a problem hiding this comment.
Added an scmsync specific method now
There was a problem hiding this comment.
All this checking about Flipper.enabled?(:scmsync, User.session) getting a bit out of hand by now. Can you simplify this?
There was a problem hiding this comment.
I did for the check_scmsync action
There was a problem hiding this comment.
couldn't you normalize this between remote project and scmsync anyway?
What should we keep the regressions for remote projects and deal with different workarounds there?
(Technical, the only difference between an scmsync and a remote package on api level is just the permission handling for service run and lock. Everything else should be identical, including access to build states, log files and the rest of the commands).
There are multiple pull requests from me open fixing these regressions and come with test cases demonstarting the issues...
That link is bogus - see #18062 |
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
1 similar comment
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-scmsync-package |
hellcp-work
force-pushed
the
scmsync-package
branch
from
3c821ff to
ccaea2b
Compare
hellcp-work
force-pushed
the
scmsync-package
branch
from
ccaea2b to
64c881c
Compare
5 participants
Displaying a reduced view of the packages coming from the remote scm
